This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client/service: refactor group param of spawn into an Enum #10248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharjeezy
changed the title
ordian
suggested changes
Nov 12, 2021
added 3 commits
November 12, 2021 22:57
bkchr
suggested changes
Nov 13, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
change specific to actual in enum declaration
…to-enum' into dharjeezy/refractor-group-param-to-enum # Conflicts: # client/service/src/task_manager/mod.rs
ordian
reviewed
Nov 13, 2021
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround, we're almost there!
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
bkchr
reviewed
Nov 13, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
|
(Hopefully) one last thing: please do |
ordian
added
A0-please_review
Contributor
Author
I have done as instructed @ordian kindly review |
ordian
approved these changes
Nov 14, 2021
Contributor
Author
|
Hello @ordian I was thinking I'd get a tip of DOT tokens after you approved my PR? |
Contributor
Author
|
Awaiting your review @bkchr |
bkchr
approved these changes
Nov 15, 2021
bkchr
added
the
D3-trivial 🧸
Member
|
bot merge |
|
Waiting for commit status. |
Member
|
Ty @dharjeezy |
Contributor
Author
|
Hello @bkchr I see you have merged the changes. |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…h#10248) * refractored group param to enum * refractored group param to enum * changed group param to GroupName enum for other methods too such as spawn_inner updated docs * revert on task type * put back ticks in GroupName * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * document group name change specific to actual in enum declaration * change documentation * Update client/service/src/task_manager/mod.rs Co-authored-by: Andronik Ordian <write@reusable.software> * changed Actual to Specific * Update client/service/src/task_manager/mod.rs Co-authored-by: Andronik Ordian <write@reusable.software> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Damilare <dakinlose@teamapt.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Andronik Ordian <write@reusable.software>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…h#10248) * refractored group param to enum * refractored group param to enum * changed group param to GroupName enum for other methods too such as spawn_inner updated docs * revert on task type * put back ticks in GroupName * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * document group name change specific to actual in enum declaration * change documentation * Update client/service/src/task_manager/mod.rs Co-authored-by: Andronik Ordian <write@reusable.software> * changed Actual to Specific * Update client/service/src/task_manager/mod.rs Co-authored-by: Andronik Ordian <write@reusable.software> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/task_manager/mod.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Damilare <dakinlose@teamapt.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Andronik Ordian <write@reusable.software>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refractor group param to group name enum as mentioned in issue #10241
Polkadot address:
12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku